CLOUDP-278929: Send a remind if an API version is approching the release date #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tibulca
reviewed
Oct 17, 2024
| done | ||
|
|
||
| if [[ ${#dates_within_3_weeks[@]} -gt 0 ]]; then | ||
| echo "API Versions that will be release in the next 3 weeks: ${dates_within_3_weeks[*]}" |
There was a problem hiding this comment.
this will get quite noisy (every day, for 3 weeks in a row, we'll get this notification and tag @apix-2-on-call).
Is it too complicated to have this trigger conditions?
- isMonday and an API version is going to be released withing the next 3 weeks
- isWeekday and an API version is going to be released withing the 6 days (this is the release week)
There was a problem hiding this comment.
isWeekday and an API version is going to be released withing the 6 days (this is the release week)
Isn't this still too noisy during the release week? I think that having the message only on Monday should be enough. WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR introduces a new GitHub Action that runs daily to verify that the API versions listed in the versions.json file in the development environment are not nearing their release dates (less than three weeks away). If there are any upcoming API versions scheduled for release, the action sends a notification to the team’s Slack channel.
Jira ticket: CLOUDP-278929