Add function Math.nearestInteger #4495
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beutlich
added
enhancement
henrikt-ma
reviewed
Nov 12, 2024
henrikt-ma
requested changes
Nov 12, 2024
henrikt-ma
requested changes
Nov 12, 2024
beutlich
force-pushed
the
add-nearest-integer
branch
from
2ef733c
to
5c4e708
Compare
HansOlsson
reviewed
Nov 14, 2024
There was a problem hiding this comment.
The general idea is good, but when using it outside of functions it becomes messy.
It seems we need the annotation GenerateEvents=true and update such functions in terms of variability, e.g., along the lines of modelica/ModelicaSpecification#3610
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #3247 as proposed by #3247 (review).