bugfix - Prevent passwordstore lookup to create subkey when create ==…

… false Close #ansible-collections#9105
mluzarreta · Nov 7, 2024 · 4f9bf46 · 4f9bf46
1 parent e13d6de
commit 4f9bf46
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/changelogs/fragments/????-passwordstore-fix-subkey-creation-even-when-create-==-false.yml b/changelogs/fragments/????-passwordstore-fix-subkey-creation-even-when-create-==-false.yml
@@ -0,0 +1,2 @@
+bugfixes:
+  - passwordstore lookup plugin - Fix subkey creation even when `create == false`. 
diff --git a/plugins/lookup/passwordstore.py b/plugins/lookup/passwordstore.py
@@ -582,9 +582,9 @@ def run(self, terms, variables, **kwargs):
                     if self.paramvals['overwrite']:
                         with self.opt_lock('write'):
                             result.append(self.update_password())
-                    elif self.paramvals["subkey"] != "password" and not self.passdict.get(self.paramvals['subkey']):  # password exists but not the subkey
-                        with self.opt_lock('write'):
-                            result.append(self.update_password())
+                        if self.paramvals["subkey"] != "password" and not self.passdict.get(self.paramvals['subkey']):  # password exists but not the subkey
+                            with self.opt_lock('write'):
+                                result.append(self.update_password())
                     else:
                         result.append(self.get_passresult())
                 else:                     # password does not exist