Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: typo in documentation of LearnerRegrKM; drop redundant task$truth() in .train #324

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions R/LearnerRegrKM.R
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#' Kriging regression.
#' Calls [DiceKriging::km()] from package \CRANpkg{DiceKriging}.
#'
#' * The predict type hyperparameter "type" defaults to "sk" (simple kriging).
#' * The predict type hyperparameter "type" defaults to "SK" (simple kriging).
#' * The additional hyperparameter `nugget.stability` is used to overwrite the
#' hyperparameter `nugget` with `nugget.stability * var(y)` before training to
#' improve the numerical stability. We recommend a value of `1e-8`.
Expand Down Expand Up @@ -91,7 +91,7 @@ LearnerRegrKM = R6Class("LearnerRegrKM",
}

invoke(DiceKriging::km,
response = task$truth(),
response = truth,
design = data,
control = pv$control,
.args = remove_named(pv, c("control", "nugget.stability"))
Expand Down