json-bigint based implementation #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Full rework of library. As for now it is based on json-bigint, internally, our json representation (Aeson) relies on BigNumber from bignumber.js, to represent numbers. This allows us deserialize/serialize JSONs holding arbitrary size numbers, including numbers with floating point.
…to uhbi19-k.havryliuk/json-bigint Drop AesonEncoder etirely
klntsky
requested changes
Dec 1, 2022
|
#12 will be probably closed too by this PR. |
kirill-havryliuk
changed the title
kirill-havryliuk
changed the title
kirill-havryliuk
force-pushed
the
uhbi19-k.havryliuk/json-bigint
branch
from
cc196be
to
9409e24
Compare
Use Argonaut errors. Better errors. Export from* family of functions Cleanups. Aeson Eq now performs deep structural equalty of underlying entities.
kirill-havryliuk
force-pushed
the
uhbi19-k.havryliuk/json-bigint
branch
from
9409e24
to
e83956f
Compare
uhbif19
suggested changes
Dec 3, 2022
|
@klntsky @kirill-havryliuk Resolved already covered comments. |
klntsky
requested changes
Dec 5, 2022
`BigInt`s and `Numbers` to avoid serialization of Infinity and NaN Full tests rewrite. Refactoring. Cleanups.
kirill-havryliuk
changed the title
kirill-havryliuk
changed the title
|
@klntsky @kirill-havryliuk Looks like all issues resolved, no? Merge it? |
@uhbif19 I would like to refactor CTL so it is based on this version first, so if we miss something we still can add it here, and not introduce new PR. |
kirill-havryliuk
changed the title
uhbif19
reviewed
Dec 14, 2022
packages.dhall
Outdated
| @@ -137,51 +137,6 @@ let additions = | |||
| , repo = "https://github.com/garyb/purescript-mote" | |||
| , version = "v1.1.0" | |||
| } | |||
| -- , medea = | |||
uhbif19
reviewed
Dec 14, 2022
src/Aeson.purs
Outdated
| @@ -406,8 +415,9 @@ caseAesonBigInt def f = | |||
| else Nothing | |||
| ) | |||
|
|
|||
| -- | The reson we return `Finite BigNumber` instead plain `BigNumber` | |||
| -- | is to simplify things like `caseAesonBigNumber _ fromFiniteBigNumber` | |||
| -- | The reson we return `Finite BigNumber` instead of a plain `BigNumber`, | |||
There was a problem hiding this comment.
Suggested change
| -- | The reson we return `Finite BigNumber` instead of a plain `BigNumber`, | |
| -- | The reason we return `Finite BigNumber` instead of a plain `BigNumber`, |
uhbif19
reviewed
Dec 14, 2022
klntsky
reviewed
Dec 14, 2022
test/Gen.purs
Outdated
| else map (i <> _) $ go (_size - lenI) | ||
|
|
||
| negSign <- arbitrary | ||
| -- forceSign <- arbitrary |
test/Gen.purs
Outdated
| <> when withFractional ("." <> fracPart) | ||
| <> when withExp ("e" <> expSign <> expPart) | ||
| where | ||
| -- sign = if negSign then "-" else when forceSign "+" |
kirill-havryliuk
force-pushed
the
uhbi19-k.havryliuk/json-bigint
branch
from
058d1fe
to
7a0d9b3
Compare
klntsky
approved these changes
Dec 14, 2022
3 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12, #11
Full rework of library. Breaking changes.
From now it is based on json-bigint (#11 ).
Internally, our json representation (Aeson) relies on BigNumber from bignumber.js, to represent numbers.
This allows us deserialize/serialize JSONs holding arbitrary size numbers, including numbers with floating point.