Remove 'orUrl' from 'modelNameOrUrl' in objectDetector #1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This naming seems misleading to me - it seems like maybe there was thought to include the ability to use a web url for other models, but the code only uses yolo or coco, and defaults to coco if a url is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objectDetector used 'modelNameOrUrl' as the name for the model parameter. This naming seems misleading to me - it seems like maybe there was thought to include the ability to use a url for other models, but the code only uses yolo or coco, and defaults to coco if a url is used with no warning.
For example:
objectDetector('./myModel.json')orobjectDetector('https://myWebsite.com/myModel.js')will both result in cocossd being used. To me, this means this parameter only takes a 'modelName'.