-
Notifications
You must be signed in to change notification settings - Fork 679
prevent panic in TextUnmarshallerHookFunc #328
Conversation
if reflect.Kind is reflect.String, it doesn't necessary means it's `string` type. It can be string-based type
Fixes #327 |
It's very questionable if |
@mitchellh with all respect, does anyone helping you with PRs? There are many open with bug fixes that should be merged into upstream. |
@mitchellh ping |
@mitchellh Could you please take a look on this fix? Many thanks! |
Thanks, it works for me. @mitchellh I would appreciate this, if you could merge this. |
@mitchellh Will this affect the future of this project? https://www.theregister.com/2023/12/15/hashimoto_departs_hashicorp/ |
Not specifically that. As many here have probably noticed, I’ve barely been maintaining this project for years. That’s a mixture of a few things. One is that this project has worked well for my needs for a long time so there was no need to improve it for myself personally. Another is that I’ve been using Go less and less personally so I just haven’t been focused here. Etc. I plan on archiving this project sometime soon, and welcome any forks at this point… |
@mitchellh We use mapstructure in Viper extensively. I'd be happy to maintain a fork. Even under a common place like https://github.com/go-viper if other people are interested in maintenance. |
@sagikazarmark Terraform should show some personal interest in maintenance as well 😁 With MIT license, anybody can create a fork. No need to transfer the project. |
if reflect.Kind is reflect.String, it doesn't necessary means it's
string
type. It can be string-based type