Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash completion: add support for git 2.30 and on #3342

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Feb 2, 2024

  1. bash completion: add support for git 2.30 and on

    The _git backwards compat wrapper was dropped upstream:
    git/git@441ecda
    
    Instead, we rely on __git_complete to detect loaded bash completions,
    since we will use it later on to set up completions -- it is now public
    API.
    
    There is a gap between git 2.30 and 2.31 where _git does not exist, but
    there is no public API to create completions. Starting 2.31, we are
    formally permitted to copy/imitate the upstream completions with:
    
    ```
    __git_complete mycmd git_cmd
    ```
    
    For 2.30 specifically, we have to pass the internal completion function
    used instead of "git_cmd", but it's difficult to detect this necessity
    in a forwards-compatible way. Try it that way first, in the assumption
    that if the internal completion function still exists it does the same
    thing.
    eli-schwartz committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    637cbbb View commit details
    Browse the repository at this point in the history