Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use connection cache instead of Net.ctx as Client.ctx #1075

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use connection cache instead of Net.ctx as Client.ctx #1075

wants to merge 1 commit into from

Conversation

madroach
Copy link
Contributor

This is a proposal to make the semantics of connection cache and Net.ctx in the Cohttp_lwt.Client module clearer.
This change is essentially summarized in cohttp-lwt/src/client.mli:

 module Make (Connection : S.Connection) :
-  S.Client with type ctx = Connection.Net.ctx
+  S.Client with type ctx = S.call

This is just a proof-of-concept on how to fix #1074

@madroach
Use connection cache instead of Net.ctx as Client.ctx
13cfdbd 
Since a connection cache already includes Net.ctx, this makes the semantics of the Client module clearer.
@madroach madroach mentioned this pull request Jul 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@madroach