Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade all outdated deps and upgrade libs with CVEs #1123

Closed
wants to merge 1 commit into from

Conversation

harshavardhana
Copy link
Member

@harshavardhana harshavardhana commented Apr 11, 2023

fixes #1118

@harshavardhana
Copy link
Member Author

@prakashsvmx can you help me with the above CI error, for some reason this runs fine with node v18.x

@peter-siebold
Copy link

Hey there, just stumbled upon the PR (I use minio.js in one project as well. Big thanks for your work btw.)

I played around with it with node v12.22.12 and the provided package.json in the PR.
Could reproduce the issue (worked with node 18.x but failed with 12.22.12) and what worked for me locally was to bump the babel/core and presets

    "@babel/core": "^7.21.4",
    "@babel/preset-env": "^7.21.4",

and in the gulpfile to add a transformer

const babelify = require('babelify')

// ... snip

exports.browserify = gulp.series(compile, () => {
  return browserify('./dist/main/minio.js', {
    standalone: 'MinIO'
  })
    .transform(babelify, {presets: ['@babel/preset-env']})
    .bundle()
    .on('error', (err) => {
      // eslint-disable-next-line no-console
      console.log('Error : ' + err.message)
    })
    .pipe(fs.createWriteStream('./dist/main/minio-browser.js'))
})

hope that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

please upgrade xml2js to ^0.5.0 to fix CVE-2023-0842 alert
2 participants