Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mineclone2,Mineclonia,Mineclone5 support. #625

Open
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

JamesClarke7283
Copy link

@JamesClarke7283 JamesClarke7283 commented Dec 20, 2023

Ive added basic Mineclone2 support, the only bug that i know is the formspecs dont show the item slots unless you hover over them. Could someone suggest a fix for this?

Checklist:

Main

  • Recipes
  • Custom MineClone Craftguide Recipes
  • Make Nodes Breakable

Extra (For appearance and gameplay)

  • Formspec's
  • Transfer Technic Manual to ingame mcl_doc documentation.

Tests

  • Check Mod runs on MTG
  • Check Mod runs on Mineclone2
  • Check Mod works without moreores.

@JamesClarke7283 JamesClarke7283 marked this pull request as draft December 20, 2023 08:23
extranodes/init.lua Outdated Show resolved Hide resolved
concrete/mod.conf Outdated Show resolved Hide resolved
extranodes/init.lua Outdated Show resolved Hide resolved
concrete/init.lua Outdated Show resolved Hide resolved
technic/machines/HV/forcefield.lua Outdated Show resolved Hide resolved
technic/tools/mining_lasers.lua Outdated Show resolved Hide resolved
technic_worldgen/oregen.lua Show resolved Hide resolved
technic_worldgen/nodes.lua Outdated Show resolved Hide resolved
technic_cnc/cnc_materials.lua Show resolved Hide resolved
technic_worldgen/init.lua Outdated Show resolved Hide resolved
@JamesClarke7283 JamesClarke7283 marked this pull request as ready for review December 27, 2023 17:12
@JamesClarke7283 JamesClarke7283 marked this pull request as draft December 27, 2023 17:55
@JamesClarke7283 JamesClarke7283 marked this pull request as ready for review December 27, 2023 17:56
@JamesClarke7283
Copy link
Author

Don't merge it yet, just let me know if you are happy with what i have done so far.

@SmallJoker
Copy link
Member

SmallJoker commented Dec 28, 2023

Might it be possible to do one mod at a time; perhaps technic first? Reviewing >1000 changed lines in a single PR is not something I'd like to do. After that one's working and merged, the other mods could be converted in a similar fashion based on the review comments of the first PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants