Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make circular saw and all cut nodes considered as non-ground content #204

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

SwissalpS
Copy link
Contributor

Let's please consider any cut node not to be ground content.
This PR:

  • sets circular saw to be non ground content.
  • sets all nodes defined from this mod to non ground content, but provides a way to register the few that were considered ground content as such.
  • sets all cut nodes (stairs, slabs, etc.) to be treated as non ground content by default, while providing mods to be able to register theirs as ground content if they explicitly want to.

see pandorabox-io/pandorabox.io#836

Default to not being ground content.
The few nodes that were registered as ground content shouldn't be considered ground content.
By default make cut nodes non ground content but allow mods to register theirs as ground content if they want to.
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Calinou Calinou merged commit 54b2217 into minetest-mods:master Feb 27, 2024
1 check passed
@Calinou Calinou changed the title Is ground content do-over Make circular saw and all cut nodes considered as non-ground content Feb 27, 2024
@SwissalpS SwissalpS deleted the is_ground_content branch February 27, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants