-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gitlab: Add support for the Release
entity
#4706
Conversation
Minder Vulnerability Report ✅Minder analyzed this PR and found it does not add any new vulnerable dependencies.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependency Information
Minder analyzed the dependencies introduced in this pull request and detected that some dependencies do not meet your security profile.
📦 Dependency: golang.org/x/mod
Trusty Score: 0
Scoring details
Component | Score |
---|---|
Repository activity | 0 |
From | activity |
Package activity | 0 |
Trust-summary | 2.7 |
Provenance | 10 |
User activity | 0 |
fb3d316
to
81a01df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependency Information
Minder analyzed the dependencies introduced in this pull request and detected that some dependencies do not meet your security profile.
📦 Dependency: golang.org/x/mod
Trusty Score: 0
Scoring details
Component | Score |
---|---|
Trust-summary | 0 |
Provenance | 10 |
User activity | 0 |
Repository activity | 0 |
From | activity |
Package activity | 0 |
81a01df
to
312e2fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependency Information
Minder analyzed the dependencies introduced in this pull request and detected that some dependencies do not meet your security profile.
📦 Dependency: golang.org/x/mod
Trusty Score: 0
Scoring details
Component | Score |
---|---|
Provenance | 10 |
User activity | 0 |
Repository activity | 0 |
From | activity |
Package activity | 0 |
Trust-summary | 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependency Information
Minder analyzed the dependencies introduced in this pull request and detected that some dependencies do not meet your security profile.
📦 Dependency: golang.org/x/mod
Trusty Score: 0
Scoring details
Component | Score |
---|---|
Trust-summary | 0 |
Provenance | 10 |
User activity | 0 |
Repository activity | 0 |
From | activity |
Package activity | 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependency Information
Minder analyzed the dependencies introduced in this pull request and detected that some dependencies do not meet your security profile.
📦 Dependency: golang.org/x/mod
Trusty Score: 0
Scoring details
Component | Score |
---|---|
From | activity |
Package activity | 0 |
Trust-summary | 0 |
Provenance | 10 |
User activity | 0 |
Repository activity | 0 |
Release
entity.Release
entity
Signed-off-by: Juan Antonio Osorio <[email protected]>
This also renames `tag_name` to just `tag` Signed-off-by: Juan Antonio Osorio <[email protected]>
Signed-off-by: Juan Antonio Osorio <[email protected]>
90f9411
to
c58f99a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think there are a few other properties that we should capture but this is an awesome start. Thanks!
// TODO: Should we explicitly handle upcoming/historical releases? | ||
|
||
switch { | ||
case releaseEvent.Action == "create": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be constants in the gitlab module but they are missing them. I'll add them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow up xanzy/go-gitlab#2032
Summary
This adds preliminary support for the
Release
entity within the gitlab provider.A release is based on a tag and has branch information (critical for remediating the flow).
Note that it requires #4704 to merge beforehand.
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: