Api: colon parameter can be separated by dot [Closes #21]

milo · Jul 12, 2017 · 20a6ead · 20a6ead
1 parent 7dadbf9
commit 20a6ead
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/Github/Api.php b/src/Github/Api.php
@@ -368,7 +368,7 @@ protected function expandColonParameters($url, array $parameters, array $default
 	{
 		$parameters += $defaultParameters;
 
-		$url = preg_replace_callback('#(^|/):([^/]+)#', function($m) use ($url, & $parameters) {
+		$url = preg_replace_callback('#(^|/|\.):([^/.]+)#', function($m) use ($url, & $parameters) {
 			if (!isset($parameters[$m[2]])) {
 				throw new MissingParameterException("Missing parameter '$m[2]' for URL path '$url'.");
 			}

diff --git a/tests/Github/Api.expandColonParameters.phpt b/tests/Github/Api.expandColonParameters.phpt
@@ -28,6 +28,8 @@ test(function() {
 		':a/' => 'A?b=B',
 		'/:a/' => '/A?b=B',
 		'/:a/:b/c' => '/A/B/c',
+		'/:a.:b/c' => '/A.B/c',
+		'/:a...:b/c' => '/A...B/c',
 	];
 
 	foreach ($urls as $url => $expected) {