Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated README.md with installation instructions for prezto #30

Merged
merged 3 commits into from
Sep 19, 2017
Merged

updated README.md with installation instructions for prezto #30

merged 3 commits into from
Sep 19, 2017

Conversation

sergiorussia
Copy link
Contributor

@miekg, i really love lean prompt and want it to be included in prezto framework. so:

  1. i ask for your approval to include lean into prezto. it would be included via git submodule and i already have appropriate patches for prezto
  2. before being included into prezto i want to enhance lean a bit so that it will fit better. for my daily needs i use Python a lot so here's the optional Python module support

here's the demo of what it would look like with my patch:

# assuming prezto setting zstyle ':prezto:module:python:info:virtualenv' format '(py %v) '
# right side of prompt is omitted for clarity

% tmux new -s lean
t % workon someenv
t (py someenv) % vim
[1]  + 907 suspended  vim
[1+] t (py someenv) % 

% workon someenv
(py someenv) %

@miekg
Copy link
Owner

miekg commented Sep 19, 2017

Thanks!

  1. Go ahead; permission granted :-)
  2. For this python stuff (I don't care at all about python :) ), just use:
    PROMPT_LEAN_LEFT and PROMPT_LEAN_RIGHT, those were added for exactly this (python) use case

@sergiorussia
Copy link
Contributor Author

um. could you help with setting up PROMPT_LEAN_LEFT correctly? as i understand i should put export PROMPT_LEAN_LEFT="${python_info[virtualenv]}" into zshenv, but python_info is not available there. if i put it into zshrc, then it simply does nothing :(

@miekg
Copy link
Owner

miekg commented Sep 19, 2017 via email

@sergiorussia
Copy link
Contributor Author

sergiorussia commented Sep 19, 2017

ok, put it another way: how can i set some dynamic info into PROMPT_LEAN_*** variables? what is the proper way? by dynamic i mean info that is changed between commands in terminal (like job count etc)

@sergiorussia
Copy link
Contributor Author

oh i just found the way, PROMPT_LEAN_*** are being evaluated each time :)

@sergiorussia
Copy link
Contributor Author

so i'm closing PR, no changes are required here :)

@sergiorussia sergiorussia reopened this Sep 19, 2017
@sergiorussia
Copy link
Contributor Author

@miekg i've updated README.md and reverted the rest

@miekg
Copy link
Owner

miekg commented Sep 19, 2017

Ok, please drop everything (and including) after "You can custom..." as that is different then configuring pretzo.

I also don't understand what "unless lean is included" means in this context, then I don't need to do anything? How do I know it is "included"?

@sergiorussia sergiorussia changed the title optional support for python module from zprezto updated README.md with installation instructions for prezto Sep 19, 2017
@sergiorussia
Copy link
Contributor Author

why that is different? places for customizations are tied to prezto file structure and as a user i want to know where should i put them. eg prompt colors should go to zshenv, but not to zshrc, etc.

lean will be included shortly :) user can find if it is included or not via prompt command. the issue here is that prezto submodules have only README files from original repositories, ie there's no way for prezto users to know how to properly use submodule X other than looking at its included documentation

@miekg
Copy link
Owner

miekg commented Sep 19, 2017

I don't understand. Is it included or not? If it is we don't need any of the text?

The customization bit is, frankly, pretzo's problem, so please remove it, we already have documented the various PROMPT_LEAN_( variables in the README.

@sergiorussia
Copy link
Contributor Author

fixed, take a look

@miekg
Copy link
Owner

miekg commented Sep 19, 2017

thank you

@miekg miekg merged commit 57cca1a into miekg:master Sep 19, 2017
@sergiorussia
Copy link
Contributor Author

@miekg , i'm adding lean to prezto here sorin-ionescu/prezto#1472 . thanks for such useful minimalist theme :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants