Add 'open image' context in markdown preview #234649
Open
+64
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notoriousmango
force-pushed
the
feat-open-image
branch
from
eb2624a
to
0b24327
Compare
|
@microsoft-github-policy-service agree |
mjbvz
reviewed
Nov 26, 2024
| @@ -679,6 +686,12 @@ export class DynamicMarkdownPreview extends Disposable implements IManagedMarkdo | |||
| }); | |||
| } | |||
|
|
|||
| openImage(imagePath: string): void { | |||
There was a problem hiding this comment.
Let's move this code into the command. The second argument to vscode.open is a ViewColumn if you need to open in a specific editor group
|
|
||
| public execute(args: { resource: string, imageSource: string }) { | ||
| const source = vscode.Uri.parse(args.resource); | ||
| const { fsPath } = vscode.Uri.parse(args.imageSource); |
There was a problem hiding this comment.
Keep this as a uri. Otherwise it will only work for file: images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #184553
This pull request aims to check whether an
img.srcis local or not, given that a localsrcattribute is automatically changed to a URI internally.I've utilized the fact that any non-local
srcattribute will not be altered, providing a basis for differentiation.I'm open to any suggestions for better ways to achieve this.