Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding overtype mode #233188

Open
wants to merge 45 commits into
base: main
Choose a base branch
from
Open

Adding overtype mode #233188

wants to merge 45 commits into from
+649 −167

Conversation

aiday-mar
Copy link
Contributor

@aiday-mar aiday-mar commented Nov 6, 2024 •
edited
Loading

fixes #1012

@aiday-mar aiday-mar self-assigned this Nov 6, 2024
@aiday-mar aiday-mar changed the title Adding setting to enable overtype mode [DRAFT]: Adding setting to enable overtype mode Nov 6, 2024
@aiday-mar
adding a setting to determine the cursor style in overtype mode
5b951f7
@aiday-mar
adding action to toggle between overtype and insert mode
b17acbe
@aiday-mar
adding a contribution which adds a statu bar icon
1fd450b
@aiday-mar
adding same as tab focus mode
c3b3496
@aiday-mar
polishing
f15cac5
@aiday-mar
polish
e8fd730
@aiday-mar
updating by clicking on the status bar
0d07ee0
@aiday-mar
polish
01de87e
@aiday-mar
changing the name of the status bar
5048d07
@aiday-mar
add some keybindings and make status bar less prominent
4a2b843
@aiday-mar
polishing the replacement of text
779035d
@aiday-mar
adding overtype on paste
900af97
@aiday-mar
adding pasting support
0949847
@aiday-mar
using paste on distributed cursors
0968f6d
@aiday-mar
fix ReplaceOvertypeCommandWithOffsetCursorState
fb0434c
@aiday-mar
add code
5706284
@aiday-mar
adding support for composition
44c77db
@aiday-mar
undoing edit context changes
5f03a29
@aiday-mar
changing the status bar entry so it disappears when moving to insert …
669ecc1 
…mode
@aiday-mar
rerender the cursors
d848314
@aiday-mar
allowing composition over several lines
164c67d
@aiday-mar
removing log
6a6e9ae
@aiday-mar
polishing the code
24f1dab
@aiday-mar aiday-mar changed the title [DRAFT]: Adding setting to enable overtype mode Adding overtype mode Nov 13, 2024
@aiday-mar aiday-mar marked this pull request as ready for review November 13, 2024 16:16
@aiday-mar aiday-mar marked this pull request as draft November 13, 2024 16:16
@aiday-mar aiday-mar mentioned this pull request Nov 15, 2024
Open
@GitMensch
Copy link
Contributor

Without inspecting the code changes it looks to me like this PR could use some squashing of commits. One big is possibly too big, but 26 commits seems too much.

Apart from this, will documentation added separately or should this PR also include some?

@aiday-mar
Copy link
Contributor Author

Hi this PR is set to squash merge automatically when approved. As for the documentation I am waiting on my colleague's review.

@GitMensch GitMensch mentioned this pull request Nov 18, 2024
Open
57 tasks
alexdima
alexdima requested changes Nov 19, 2024
View reviewed changes
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I left some comments.

src/vs/base/common/inputMode.ts Outdated Show resolved Hide resolved
src/vs/workbench/browser/parts/editor/editorStatus.ts Outdated Show resolved Hide resolved
src/vs/workbench/browser/parts/editor/editorStatus.ts Outdated Show resolved Hide resolved
src/vs/workbench/browser/parts/editor/editorActions.ts Outdated Show resolved Hide resolved
src/vs/editor/common/config/editorOptions.ts Outdated Show resolved Hide resolved
src/vs/editor/common/cursor/cursorTypeEditOperations.ts Outdated Show resolved Hide resolved
src/vs/editor/browser/viewParts/viewCursors/viewCursor.ts Outdated Show resolved Hide resolved
src/vs/editor/common/config/editorOptions.ts Show resolved Hide resolved
src/vs/editor/common/commands/replaceCommand.ts Outdated Show resolved Hide resolved
src/vs/editor/common/editorCommon.ts Outdated Show resolved Hide resolved
@GitMensch
Copy link
Contributor

LGTM, I'd really love to see this pulled in - @alexdima ?

auto-merge was automatically disabled November 26, 2024 09:18

Pull Request is not mergeable

alexdima
alexdima requested changes Nov 26, 2024
View reviewed changes
Copy link
Member

@alexdima alexdima left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks almost ready to merge! Left a few small comments!

src/vs/workbench/browser/parts/editor/editorStatus.ts Outdated Show resolved Hide resolved
src/vs/workbench/browser/parts/editor/editorStatus.ts Outdated Show resolved Hide resolved
src/vs/workbench/browser/parts/editor/editorActions.ts Outdated Show resolved Hide resolved
@aiday-mar aiday-mar enabled auto-merge (squash) November 27, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitMensch GitMensch GitMensch left review comments

@alexdima alexdima alexdima requested changes

@fmendoza-pf fmendoza-pf fmendoza-pf approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@aiday-mar aiday-mar

Labels
None yet
Projects
None yet
Milestone
November 2024
Development

Successfully merging this pull request may close these issues.

Insert key doesn't switch to overtype/overwrite mode
4 participants
@aiday-mar @GitMensch @alexdima @fmendoza-pf