-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
markdown preview: allow opening images in a new editor #184553
Comments
This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation. Happy Coding! |
This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation. Happy Coding! |
what do you mean by |
Hey, I would like to work on this issue .. @mjbvz |
@mjbvz can i work on this |
Yes, since this is a smaller feature feel free to start working and submit a PR when it's ready or you need some early feedback/pointers |
@mjbvz i working in this issue done all the ui things.
now i have to write the openImage function but i can find any inbuilt methods or vscode api to open image in new tab. can you help me @mjbvz
|
@Gobinath-B can I work on this with you? |
Yeah sure. For now I added open image button next to copy image. Only thing I have to do is write a function using vscode api or call a existing open image function to give functionality to the button |
I managed to call the open image function, but currently it doesn't do anything. I have been looking for open in new tab functionality. |
Can you share the location of image opening functionality |
The function that you made |
We can use |
Hi @mjbvz, I have a working implementation for images present in the current workspace folder. I need some help dealing with cases where there is no workspace folder present. Do I just make a new pull request? |
@MSViswanth , I working on this issue first. I'm worried that your action wasting both of our time. Feel free to find another issue to work. If you are comfortable to help me on this issue ,I'm appreciate that. But working on the same issue either waste your time or my time. |
@Gobinath-B Well, alright. I would have liked you to merge my changes instead of just copying them. |
Thanks @MSViswanth |
Images opened in the markdown preview could have a context menu that includes 'Open Image' that opens the image in a new editor.
The text was updated successfully, but these errors were encountered: