Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

partially support virtual workspace #186

Merged
merged 2 commits into from
Sep 6, 2021
Merged

partially support virtual workspace #186

merged 2 commits into from
Sep 6, 2021

Conversation

Eskibear
Copy link
Member

See #185

Virtual workspace is e.g. when you open GitHub repo directly in VS Code where scheme of URI is vscode-vfs instead of file.

In this PR:

  • Declare virual workspaces capability in package.json
  • Hide "create project" from command palatte.
  • Refactor "add starters" to support virtual workspaces.

PS:
Must use vscode.workspace.fs (since v1.37.0) instead of native NodeJS fs.

@Eskibear
add license
bba1041 
Signed-off-by: Yan Zhang <[email protected]>
@Eskibear
Copy link
Member Author

Eskibear commented May 12, 2021 •
edited
Loading

Here is a demo:

SpringInitializr-virtualWorkspace.mp4

@Eskibear Eskibear merged commit ed2fc6e into main Sep 6, 2021
@Eskibear Eskibear deleted the virtual-workspace branch September 6, 2021 09:00
@Eskibear Eskibear added this to the 0.8.0 milestone Sep 6, 2021
@Eskibear Eskibear mentioned this pull request Feb 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdneo jdneo jdneo left review comments

@akaroml akaroml Awaiting requested review from akaroml

@testforstephen testforstephen Awaiting requested review from testforstephen

@CsCherrYY CsCherrYY Awaiting requested review from CsCherrYY

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Eskibear @jdneo