Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cache to reveal resource #887

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use cache to reveal resource #887

wants to merge 2 commits into from

Conversation

nturinski
Copy link
Member

There was already an item cache being used for storing the relationship data between parent and child. I was able to just leverage that to make reveal a lot faster if something has already been loaded before.

The next step to improving performance is to the do following across extensions:

  1. Make resources resolve faster by not requiring the Azure API call until after it is expanded
  2. Change all extensions that resolve the resources with multi
    ple GET calls use the LIST call. There is some concern about the caching that messes things up that we should consider, however, such as deleting too many resources at once and the cached list doesn't update to reflect that.

reveal_cache

@nturinski nturinski requested a review from a team as a code owner July 25, 2024 17:26
@alexweininger
Copy link
Member

Do we need to reevaluate the need for this now that we've fixed the resolver caching?

@nturinski
Copy link
Member Author

Hmm, I don't really see the harm in merging this considering the itemCache already existed. Might as well leverage it if we had already loaded the child once before.

Other than using the cache, I don't think that this changes the behavior of anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants