Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r8brain-free-src] add new port #42256

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[r8brain-free-src] add new port #42256

wants to merge 4 commits into from
+138 −0

Conversation

CrSjimo
Copy link
Contributor

@CrSjimo CrSjimo commented Nov 20, 2024

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@BillyONeal
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

dg0yt
dg0yt reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@dg0yt dg0yt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CMakeLists.txt should be just copied, for easy editing.

The CMake config must adopt the unofficial prefix pattern.

The source shares code which is in port pffft.

@BillyONeal
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Mengna-Li Mengna-Li added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Nov 21, 2024
@BillyONeal
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@CrSjimo
Copy link
Contributor Author

CrSjimo commented Nov 21, 2024

The CMakeLists.txt should be just copied, for easy editing.

The CMake config must adopt the unofficial prefix pattern.

The source shares code which is in port pffft.

@dg0yt What is your intention in mentioning "The source shares code which is in port pffft"? Should I use port pffft as a dependency instead of what is included in the upstream source code? But in that way, this port does not use the upstream source code as-is.

@Mengna-Li
Copy link
Contributor

You should create a new CMakeList.txt file in the port/r8brain-free-src path.
Add the prefix 'unofficial' to the targets.

Mengna-Li
Mengna-Li requested changes Nov 25, 2024
View reviewed changes
ports/r8brain-free-src/CMakeLists.txt Outdated

if(R8B_INSTALL)
install(TARGETS r8bsrc
EXPORT ${PROJECT_NAME}Targets
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the prefix 'unofficial' to all your exports.

ports/r8brain-free-src/CMakeLists.txt Outdated
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/r8brain/pffft_double
)
endif()
endif()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a new line at the end of the file.

ports/r8brain-free-src/portfile.cmake Outdated
vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO avaneev/r8brain-free-src
REF version-${VERSION}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
REF version-${VERSION}
REF "version-${VERSION}"

ports/r8brain-free-src/portfile.cmake Outdated
SHA512 ae2707aa76d3dc89153bbe755f134c497a6024d3bc06badbb078fe8bc5c7f09bfa277003c6915b341f35d86224930890abab89da0ebafb98722cf35f9a2222d9
)

file(COPY ${CMAKE_CURRENT_LIST_DIR}/CMakeLists.txt DESTINATION ${SOURCE_PATH})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
file(COPY ${CMAKE_CURRENT_LIST_DIR}/CMakeLists.txt DESTINATION ${SOURCE_PATH})
file(COPY "${CMAKE_CURRENT_LIST_DIR}/CMakeLists.txt" DESTINATION "${SOURCE_PATH}")

ports/r8brain-free-src/portfile.cmake Outdated
vcpkg_copy_pdbs()

file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/include")
file(INSTALL ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
file(INSTALL ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright)
vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/LICENSE")

Mengna-Li
Mengna-Li requested changes Nov 27, 2024
View reviewed changes
ports/r8brain-free-src/portfile.cmake
Comment on lines +22 to +24
OPTIONS
-DR8B_PFFFT=${R8B_PFFFT}
-DR8B_PFFFT_DOUBLE=${R8B_PFFFT_DOUBLE}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
OPTIONS
-DR8B_PFFFT=${R8B_PFFFT}
-DR8B_PFFFT_DOUBLE=${R8B_PFFFT_DOUBLE}
OPTIONS
${FEATURE_OPTIONS}

ports/r8brain-free-src/portfile.cmake
vcpkg_copy_pdbs()

file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/include")
vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/LICENSE")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a new line at the end of the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

@Mengna-Li Mengna-Li Mengna-Li requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Mengna-Li Mengna-Li

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CrSjimo @BillyONeal @Mengna-Li @dg0yt