Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[casadi] first step (no dependencies) #41649

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

jgillis
Copy link

@jgillis jgillis commented Oct 18, 2024

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@jgillis
Copy link
Author

jgillis commented Oct 18, 2024

@microsoft-github-policy-service agree company="yacoda"

Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be more practical to format the portfile with spaces, not tabs. (Tabs are subject to settings. GH PR review looks strange.)

I see a lot of find modules. I would expect a similar set of dependencies in the manifest.

@@ -0,0 +1,39 @@
vcpkg_check_linkage(ONLY_DYNAMIC_LIBRARY)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is only about dllexport:

Suggested change
vcpkg_check_linkage(ONLY_DYNAMIC_LIBRARY)
if(VCPKG_TARGET_IS_WINDOWS)
vcpkg_check_linkage(ONLY_DYNAMIC_LIBRARY)
endif()

ports/casadi/portfile.cmake Outdated Show resolved Hide resolved
ports/casadi/usage Outdated Show resolved Hide resolved
@dg0yt
Copy link
Contributor

dg0yt commented Oct 19, 2024

Maybe put the PR in draft state as long as it is not ready for review.

@jgillis jgillis marked this pull request as draft October 19, 2024 16:44
@jgillis
Copy link
Author

jgillis commented Oct 19, 2024

@dg0yt Thanks for your review, I assumed you would not start a review while CI still runs..

CasADi works with a plugin system.
The core is basically dependency-free.
In this first version, I'm packaging the 'core' feature set.
Next up would be coin-or-ipopt dependency, but that's for another PR.
Because of the plugin system, static libraries do not currently make sense.

I'll think about adding the namespace upstream.

@jgillis jgillis marked this pull request as ready for review October 19, 2024 20:49
@jgillis
Copy link
Author

jgillis commented Oct 19, 2024

@dg0yt The CI checking seems to stall; x64_linux is compiling whole of llvm, and windows builds queue until timeout.
Is this a normal state of affairs or am I just unlucky?

@dg0yt
Copy link
Contributor

dg0yt commented Oct 19, 2024

CI has a real problem.
llvm:x64-linux is building because the PR touches ci.baseline.

@jgillis
Copy link
Author

jgillis commented Oct 19, 2024

Oh I see, thanks for helping out this vcpkg noob.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants