-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vmaware] add new port #41618
base: master
Are you sure you want to change the base?
[Vmaware] add new port #41618
Conversation
There's a note about 'usage' file. This library is header only and doesn't contain any 'usage' which can be easily generated. What should I do to add proper usage? |
ports/vmaware/portfile.cmake
Outdated
|
||
|
||
# Header only | ||
file(INSTALL "${SOURCE_PATH}/src/vmaware.hpp" DESTINATION "${CURRENT_PACKAGES_DIR}/include/vmaware") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the GPL header maybe be under a separate feature to avoid accidental usage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you propose to install headers with the same name but kinda 'toggle' which one should be installed depends on "gpl" feature enabled? If so, I think it's a good idea.
since this is header-only we don't need debug build
@@ -0,0 +1,12 @@ | |||
{ | |||
"name": "vmaware", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@t43rr7, Thanks for your new port. Could you please change the name of the port? It is difficult to find your repository kernelwernel/VMAware when searching for this port name, because it will pop up a lot of "VMware" official content, which will confuse users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What name do you suggest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about kernelwernel-VMAware?
Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags. |
Co-authored-by: JonLiu1993 <[email protected]>
Co-authored-by: JonLiu1993 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A gpl
feature also exist in ffmpeg
.
FTR the suggested implementation here is not fool-proof: When one dependency activates gpl3
, all other packages will get the GPL-licensed header, too.
"license": "GPL-3.0-only OR MIT", | ||
"features": { | ||
"gpl3": { | ||
"description": "Enable GPL-3.0 compatible code" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"license": "GPL-3.0-only OR MIT", | |
"features": { | |
"gpl3": { | |
"description": "Enable GPL-3.0 compatible code" | |
"license": "MIT", | |
"features": { | |
"gpl3": { | |
"description": "Enable GPL-3.0 licensed code", | |
"license": "GPL-3.0-only" |
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.