Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vmaware] add new port #41618

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

[Vmaware] add new port #41618

wants to merge 13 commits into from

Conversation

t43rr7
Copy link
Contributor

@t43rr7 t43rr7 commented Oct 17, 2024

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@t43rr7
Copy link
Contributor Author

t43rr7 commented Oct 17, 2024

There's a note about 'usage' file. This library is header only and doesn't contain any 'usage' which can be easily generated. What should I do to add proper usage?



# Header only
file(INSTALL "${SOURCE_PATH}/src/vmaware.hpp" DESTINATION "${CURRENT_PACKAGES_DIR}/include/vmaware")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the GPL header maybe be under a separate feature to avoid accidental usage?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you propose to install headers with the same name but kinda 'toggle' which one should be installed depends on "gpl" feature enabled? If so, I think it's a good idea.

@JonLiu1993 JonLiu1993 changed the title Vmaware port [Vmaware] add new port Oct 18, 2024
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Oct 18, 2024
since this is header-only we don't need debug build
@@ -0,0 +1,12 @@
{
"name": "vmaware",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@t43rr7, Thanks for your new port. Could you please change the name of the port? It is difficult to find your repository kernelwernel/VMAware when searching for this port name, because it will pop up a lot of "VMware" official content, which will confuse users.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What name do you suggest?

Copy link
Member

@JonLiu1993 JonLiu1993 Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about kernelwernel-VMAware?

@JonLiu1993 JonLiu1993 marked this pull request as draft October 18, 2024 07:16
@JonLiu1993
Copy link
Member

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A gpl feature also exist in ffmpeg.
FTR the suggested implementation here is not fool-proof: When one dependency activates gpl3, all other packages will get the GPL-licensed header, too.

Comment on lines +6 to +9
"license": "GPL-3.0-only OR MIT",
"features": {
"gpl3": {
"description": "Enable GPL-3.0 compatible code"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"license": "GPL-3.0-only OR MIT",
"features": {
"gpl3": {
"description": "Enable GPL-3.0 compatible code"
"license": "MIT",
"features": {
"gpl3": {
"description": "Enable GPL-3.0 licensed code",
"license": "GPL-3.0-only"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants