[VS] allow installations without the english language pack #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ras0219-msft
approved these changes
Feb 2, 2022
strega-nil-ms
pushed a commit
to strega-nil/vcpkg-tool
that referenced
this pull request
Feb 12, 2022
…#339) * [VS] allow installations without the english language pack * remove "excluded_toolsets" that's now unused * format
|
This breaks https://github.com/microsoft/vcpkg/blob/de176433e9a8769eed0e43d61758f4cdc1dc6e20/scripts/cmake/vcpkg_copy_pdbs.cmake#L21 cc @BillyONeal |
|
It is still broken: microsoft/vcpkg#41400 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title.
This still requests
VSLANG=1033, since there may be some minor build systems that don't support non-english language packs; however, we just don't fail when the english language pack isn't installed.