Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add abstraction for serialization/deserialization #5193

Merged
merged 10 commits into from
Nov 27, 2024

Conversation

live1206
Copy link
Contributor

@live1206 live1206 commented Nov 26, 2024

Resolves #4433

  • Add abstraction for serialization/deserialization to handle more types
  • handle 202 classifier
  • Make JsonElementSnippets and Utf8JsonWriterSnippets public, so that sub-plugin don't need to duplicate the implementation

@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Nov 26, 2024
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Generator.CSharp.ClientModel

@live1206 live1206 changed the title Add abstraction for serialization/deserialization and handle 202 classifier Add abstraction for serialization/deserialization Nov 26, 2024
Copy link
Member

@ArcturusZhang ArcturusZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@live1206 live1206 added this pull request to the merge queue Nov 27, 2024
Merged via the queue into microsoft:main with commit 8713c2c Nov 27, 2024
21 checks passed
@live1206 live1206 deleted the serialization-type-abstraction branch November 27, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add abstraction to deal with more types during serialization/deserialization in MGC
3 participants