-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add abstraction for serialization/deserialization #5193
Merged
live1206
merged 10 commits into
microsoft:main
from
live1206:serialization-type-abstraction
Nov 27, 2024
Merged
Add abstraction for serialization/deserialization #5193
live1206
merged 10 commits into
microsoft:main
from
live1206:serialization-type-abstraction
Nov 27, 2024
+67
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
Issue for the C# client emitter: @typespec/http-client-csharp
label
Nov 26, 2024
API change check APIView has identified API level changes in this PR and created following API reviews. |
…ive1206/typespec into serialization-type-abstraction
…ive1206/typespec into serialization-type-abstraction
live1206
changed the title
Add abstraction for serialization/deserialization and handle 202 classifier
Add abstraction for serialization/deserialization
Nov 26, 2024
...rator/Microsoft.Generator.CSharp.ClientModel/src/Providers/MrwSerializationTypeDefinition.cs
Outdated
Show resolved
Hide resolved
ArcturusZhang
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4433
JsonElementSnippets
andUtf8JsonWriterSnippets
public, so that sub-plugin don't need to duplicate the implementation