[compiler] allow ModelKit to be augmented in later kits #4882
Conversation
iscai-msft
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
microsoft-github-policy-service
bot
added
the
compiler:core
| is(type: Type): type is Model; | ||
| } | ||
|
|
||
| interface TypeKit { |
There was a problem hiding this comment.
This feels inconsitent with all the other type kit.
If we want to change it we should probably change them all(as well as get the doc on how you should name your type kits)
You can reference that model in typescript btw by doing
ModelKit["model"] // this type is the type of the model property
There was a problem hiding this comment.
I'm updating it to look like the [ModelProperty](https://github.com/microsoft/typespec/blob/main/packages/compiler/src/experimental/typekit/kits/model-property.ts) typekit, since I want to extend from the Model kit in the client library type kit I'm adding. So I need to expose a flat interface of the operations. Would a better way to keep it like this, since it's consistent with the ModelProperty def, or should I expose ModelKit["model"] as ModelKit or something like that, so I can get the flat interface out
There was a problem hiding this comment.
I guess I am not sure, I would just like our typekit to be consistent(which seems like they already are not if ModelProperty does it that way) @joheredi what do you think?
There was a problem hiding this comment.
also @bterlson, should the template for ModelProperty be the required way to define things, so that they would be automatically extensible in other typekits?
No description provided.