Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine value provider check if user passes a 'undefined' value #205

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

intellild
Copy link

@intellild intellild commented Jul 29, 2022

If user pass { useValue: undefined }, isProvider returns false,
causing

if (!isProvider(providerOrConstructor)) {
treat the object as a class

@intellild intellild changed the title allow 'undefined' value for value provider refine value provider check if user passes a 'undefined' value Jul 29, 2022
@risen228
Copy link

Fixed this in tsyringe-neo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants