Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: remove mistaken on_activate func #9839

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Python: remove mistaken on_activate func #9839

merged 2 commits into from
Nov 29, 2024

Conversation

eavanvalkenburg
Copy link
Member

Motivation and Context

Removes an outdated function on_activate from the KernelProcessStep class and the one place it was overridden.

Fixes #9829

Description

Contribution Checklist

@eavanvalkenburg eavanvalkenburg requested a review from a team as a code owner November 28, 2024 12:18
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label Nov 28, 2024
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Nov 29, 2024
Merged via the queue into microsoft:main with commit dc7cb45 Nov 29, 2024
23 of 24 checks passed
@eavanvalkenburg eavanvalkenburg deleted the fix_9829 branch November 29, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westey-m westey-m westey-m approved these changes

@moonbox3 moonbox3 moonbox3 approved these changes

Assignees
No one assigned
Labels
python Pull requests for the Python Semantic Kernel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python: Bug: Process Framework KernelProcessStep.on_activate is never called
4 participants
@eavanvalkenburg @moonbox3 @westey-m @markwallace-microsoft