[rush-lib] Fix filtered install behavior when there are dependencies …

…on other subspaces (#5019) * [rush] Fix install all projects in monorepo * [rush] Update changelogs * Update common/changes/@microsoft/rush/pedrogomes-fix-install-all-projects_2024-11-26-04-35.json Co-authored-by: Pete Gonzalez <[email protected]> --------- Co-authored-by: Pete Gonzalez <[email protected]>
microsoft · Nov 27, 2024 · 8685c7c · 8685c7c
1 parent d6079ff
commit 8685c7c
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/common/changes/@microsoft/rush/pedrogomes-fix-install-all-projects_2024-11-26-04-35.json b/common/changes/@microsoft/rush/pedrogomes-fix-install-all-projects_2024-11-26-04-35.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/rush",
+      "comment": "Fix an issue where filtered installs neglected to install dependencies from other subspaces",
+      "type": "none"
+    }
+  ],
+  "packageName": "@microsoft/rush"
+}
diff --git a/libraries/rush-lib/src/cli/actions/BaseInstallAction.ts b/libraries/rush-lib/src/cli/actions/BaseInstallAction.ts
@@ -244,6 +244,7 @@ export abstract class BaseInstallAction extends BaseRushAction {
           console.log(Colorize.green(`Installing for subspace: ${subspace.subspaceName}`));
           let installManagerOptionsForInstall: IInstallManagerOptions;
           if (subspaceInstallationData) {
+            // This will install the selected of projects in the subspace
             const { selectedProjects, pnpmFilterArgumentValues } = subspaceInstallationData;
             installManagerOptionsForInstall = {
               ...installManagerOptions,
@@ -262,8 +263,10 @@ export abstract class BaseInstallAction extends BaseRushAction {
               subspace
             };
           } else {
+            // This will install all projects in the subspace
             installManagerOptionsForInstall = {
               ...installManagerOptions,
+              pnpmFilterArgumentValues: [],
               subspace
             };
           }