Preliminary fixes and improvements to the wasm backend #812
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wasm backend seems to have bitrotted a bit, I couldn't get it to compile in the latest
dev-slice
branch, so I did some preliminary fixes and improvements. Summary of changes:prim.c
compile again by adding missing includes and moving a few helper functions around.__wasm__
macro uniformly across the codebase. This is better than__wasi__
since the linear memory characteristics really are not wasi-specific, and this macro works out of the box for both emscripten and wasi-sdk.__builtin_wasm_memory_grow
logic in the wasm backend. We always usesbrk
for wasm at the moment, which works fine as long as the argument is a multiple of wasm page size.getentropy
to fix the random buffer source for the wasm backend.getentropy
is present in the sysroots of both emscripten and wasi-sdk.