CVM: add attestation report test for Azure Linux using snpguest tool #3529
Conversation
trungams
commented
Nov 23, 2024
trungams
commented
- Extend cargo tool to support optional build parameters
- Add support for snpguest
- Extend Azure CVM attestation report test case for Azure Linux 3.0. The attestation workflow done in the test case is described in snpguest's README
Signed-off-by: Thien Trung Vuong <[email protected]>
| log_path, | ||
| ) | ||
| elif isinstance(node.os, CBLMariner): | ||
| assert_that(node.tools[SnpGuest].run_cvm_attestation()).is_true() |
There was a problem hiding this comment.
Do we not want/need to use similar parameters to the existing test?
There was a problem hiding this comment.
imo since this is the actual test case definition. Assertion should be done here rather than in the tool
There was a problem hiding this comment.
If all cases need a success result, you can assert in the tool. And please always add describe_as to provide an error message in case it happens. So it's easy to know the error in the test results, instead of digging into the code.
There was a problem hiding this comment.
Yup. Each function in the tool already has an assert for exit code = 0, and an error message in case of failure. The assert here is more or less to make it clear what we're looking for.
There was a problem hiding this comment.
- This line can be
node.tools[SnpGuest].run_cvm_attestation()). It should be enough, if the method have enough assertion already. - In case it needs to check the return code, add
described_asto provide error message for thisassert_that. Please have a try to understand the behaviors of assert_that.
Signed-off-by: Thien Trung Vuong <[email protected]>
Signed-off-by: Thien Trung Vuong <[email protected]>
Signed-off-by: Thien Trung Vuong <[email protected]>
