Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 3.0 manifests with missing deps #11235

Open
wants to merge 7 commits into
base: 3.0-dev
Choose a base branch
from

Conversation

dmcilvaney
Copy link
Contributor

@dmcilvaney dmcilvaney commented Nov 26, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Running the make validate-chroot command shows several packages missing from the chroot environment. We need these packages to be correctly installed with all their dependencies available otherwise we may get unpredictable build results (especially for packages that are often implicitly required like util-linux).

A follow on PR will improve the detection logic, however this PR will just update the manifests and fix the toolchain build.

Change Log
  • Add missing runtime requirements for a complete dependency closure in the worker chroot
    • Highlights are:
      • pam
      • pcre2 and associated sub-packages
      • libgpg-error-devel
      • libselinux
      • libsepol-devel
      • All the perl...
  • Update the toolchain build script to include:
    • perl-WWW-Curl
    • python3-pyparsing
    • python3-six
Does this affect the toolchain?

YES/NO

Associated issues
Test Methodology

@dmcilvaney dmcilvaney force-pushed the damcilva/3.0/toolchain/fix_manifests branch from 55caa94 to 0ed7c34 Compare November 27, 2024 01:24
@dmcilvaney dmcilvaney changed the base branch from 3.0 to 3.0-dev November 27, 2024 01:32
@dmcilvaney dmcilvaney marked this pull request as ready for review November 27, 2024 02:17
@dmcilvaney dmcilvaney requested a review from a team as a code owner November 27, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants