Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODEOWNERS: add cgmanifest.json to an explicit approval from mariner-devs #11228

Open
wants to merge 1 commit into
base: 3.0-dev
Choose a base branch
from

Conversation

mfrw
Copy link
Member

@mfrw mfrw commented Nov 26, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Exempt PRs targetted to SPECS-EXTENDED from stable-maintainers review

Change Log
Does this affect the toolchain?

NO

Associated issues
  • NA
Links to CVEs
  • NA
Test Methodology
  • NA

@mfrw mfrw requested a review from a team as a code owner November 26, 2024 17:43
@mfrw mfrw added 3.0-dev PRs Destined for AzureLinux 3.0 stable-release-shiproom PRs for consideration for stable shiproom labels Nov 26, 2024
@PawelWMS PawelWMS requested a review from a team November 26, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0 stable-release-shiproom PRs for consideration for stable shiproom
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant