Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kata-packages-uvm: Add make dependency #11204

Open
wants to merge 1 commit into
base: 3.0-dev
Choose a base branch
from

Conversation

ms-mahuber
Copy link
Contributor

@ms-mahuber ms-mahuber commented Nov 25, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Further streamline/simplify UVM builds

Change Log
  • add explicit dependency to make for kata-packages-uvm-bulid: allows for builds without relying on kata-packages-uvm-coco-sign (the latter package requires build-essentials with requires make).
  • remove commented package dependencies for msigvm and cose1sign tools
Does this affect the toolchain?

NO

Associated issues
  • N/A
Links to CVEs
  • N/A
Test Methodology

- add explicit dependency to make
- remove commented package dependencies

Signed-off-by: Manuel Huber <[email protected]>
@ms-mahuber ms-mahuber changed the base branch from 3.0 to 3.0-dev November 25, 2024 13:08
@ms-mahuber ms-mahuber marked this pull request as ready for review November 25, 2024 20:13
@ms-mahuber ms-mahuber requested a review from a team as a code owner November 25, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant