Move transaction event #23218
Open
Move transaction event #23218
+12
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
noencke
force-pushed
the
move-transaction-event
branch
from
33fdc75
to
1cb9ca6
Compare
noencke
commented
Nov 27, 2024
| event.type === "replace" && | ||
| getChangeReplaceType(event) !== "transactionCommit" | ||
| getChangeReplaceType(event) === "rebase" |
There was a problem hiding this comment.
This change here is purely cosmetic, as there are only two possible results from getChangeReplaceType
msfluid-bot
reviewed
Nov 27, 2024
There was a problem hiding this comment.
Code Coverage Summary
↓ packages.dds.tree.src.shared-tree:
Line Coverage Change: -0.01% Branch Coverage Change: -0.07%
| Metric Name | Baseline coverage | PR coverage | Coverage Diff |
|---|---|---|---|
| Branch Coverage | 91.64% | 91.57% | ↓ -0.07% |
| Line Coverage | 97.47% | 97.46% | ↓ -0.01% |
Baseline commit: a7bef9a
Baseline build: 310141
Happy Coding!!
Code coverage comparison check passed!!
⯆ @fluid-example/bundle-size-tests: -57 Bytes
Baseline commit: a7bef9a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move a segment of code in TreeCheckout that updates the detached field index. Rather than doing it in response to a branch change event, it can be done directly after the checkout commits a transaction. This allows the code to be simpler and more direct.