Fix binding embeded id parameter

[radovanradic]

Fix for issue #3125

[radovanradic]

@dstepanov So here is the case that DefaultParameterExpression gets value as embeded id but binding parameters should be each field of embedded id. So, we need to extract value for the param if field belongs to embedded id and passed value is embedded id. Not sure if this is safe enough and if there is some better approach to extract correct value for embedded id part(s).

[dstepanov]

I think it should be expanded in the equals operator, similar to the composite identity:

micronaut-data/data-model/src/main/java/io/micronaut/data/model/query/builder/sql/AbstractSqlLikeQueryBuilder2.java

Lines 2019 to 2032 in 74fbe2a

	public void visitEquals(Expression<?> leftExpression, Expression<?> rightExpression, boolean ignoreCase) {
	if (leftExpression instanceof io.micronaut.data.model.jpa.criteria.PersistentPropertyPath<?> persistentPropertyPath) {
	PersistentPropertyPath propertyPath = persistentPropertyPath.getPropertyPath();
	PersistentProperty property = propertyPath.getProperty();
	if (computePropertyPaths() && property instanceof Association) {
	List<IPredicate> predicates = new ArrayList<>();
	PersistentEntityUtils.traverse(propertyPath, pp ->
	predicates.add(new BinaryPredicate(
	new DefaultPersistentPropertyPath<>(pp, null),
	rightExpression,
	ignoreCase ? PredicateBinaryOp.EQUALS_IGNORE_CASE : PredicateBinaryOp.EQUALS
	))
	);
	if (predicates.size() == 1) {

[radovanradic]

Predicate and criteria is ok, association is expanded and query generated is

UPDATE `Shipment1` SET `field`=? WHERE (`sp_country` = ? AND `sp_city` = ?)

but each of these 2 bindings for WHERE criteria is ShipmentId instead of each property of the embedded id getting from here

@NotNull
    @NextMajorVersion("Require non null y")
    private Predicate predicate(Expression<?> x, Object y, PredicateBinaryOp op) {
        if (x instanceof IdExpression) {
            return new ExpressionBinaryPredicate(x, literal(y), op);
        }
        return new PersistentPropertyBinaryPredicate<>(requireProperty(x), literal(y), op);
    }

This is why we need to get actual embedded id field value in the bind method above.

[dstepanov]

That should be done a bit differently:

• We need to add PersistentPropertyPath parameterPropertyPath to DefaultParameterExpression like it's in SourceParameterExpressionImpl
• When the property is expanded, we should try to recognize DefaultParameterExpression and clone it to a new parameter with parameterPropertyPath set the left property path
• DefaultParameterExpression should use the same logic as in the source one to calculate parameterBindingPath
• DefaultBindableParametersStoredQuery should support using getParameterBindingPath for cases when the value set

[sonarcloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud