-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate/update derivative files in preparation for packaging the schema #252
Generate/update derivative files in preparation for packaging the schema #252
Conversation
These files were generated/updated by running this one-liner: ``` $ docker compose run app \ sh -c 'poetry install && make squeaky-clean all test' ``` The file `nmdc.py` was already being tracked by Git. The other 4 files were not. I ran `git add {path/to/file}` for each of those 4 files in order to make it so Git tracks them.
|
Hi @turbomam, during today's metadata meeting, I said I'd try to make a release of the Berkeley schema, including generating the derivative files. I did generate the files (they are in this PR). Then, I ran into a blocker related to GitHub permissions: I do not have permission to merge this PR into the |
I would still prefer that this be merged in before the GitHub Release gets created, so that the commit associated with the Release includes these files. (Longer term, I don't want the repo to contain derivative files—a GHA workflow can generate them and either attach them to the GitHub Release or publish them to GitHub Pages. Related: microbiomedata#1960.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think those git add operations will be remembered now as tracked files?
What permissions would have allowed you to do more of this task, if you wanted to? Here's a current permission table. I think some of those are inherited form "Base role" . I don't understand how that's different from inheriting from the Organization access. echo -e "login\tadmin\tmaintain\tpull\tpush\ttriage" > berkeley-schema-fy24_permissions.tsv ; \
gh api repos/microbiomedata/berkeley-schema-fy24/collaborators \
--jq '.[] | "\(.login)\t\(.permissions.admin)\t\(.permissions.maintain)\t\(.permissions.pull)\t\(.permissions.push)\t\(.permissions.triage)"' >> berkeley-schema-fy24_permissions.tsv
|
I still have some potentially irrational discomfort with omitting generated files form the repo. That has probably played a role in making it hard to make a schema release for a long time now, so as long as you, @pkalita-lbl, @sierra-moxon , @sujaypatil96 can a shared vision on building and deploying, I'll go along with it. I may have some scripts that pick some of that stuff up from git raw URLs, but we'll deal with that as it arises. |
I think so. They are not currently listed in any |
Because I was working after hours, I was blocked by my inability to merge a PR without review. So, being able to override that requirement would have allowed me to do more of this task. |
Closing in favor of #253 (ready for review). |
These files were generated/updated by running this one-liner, when on the tip of
main
(i.e. at commit 36e5db9), with a clean working directory:The file
nmdc.py
was already being tracked by Git. The other 4 files were not. I rangit add {path/to/file}
for each of those 4 files in order to make it so Git tracks them.