Skip to content

Commit

Permalink
[Security solution][Detection Engine] removes skipped "alerts index d…
Browse files Browse the repository at this point in the history
…oes not exist" FTR test (elastic#186789)

## Summary

- addresses elastic#179208 by removing
skipped test

I tracked skipped test to this PR:
elastic#115290

Test was added already skipped
https://github.com/elastic/kibana/pull/115290/files#diff-16cebcbaef99c1aab50640a5bee66351bcbfd7575361d97eee4d2ca6753f5a27R38-R41

In the tested route itself, when index does not exist, it returns 200:
https://github.com/elastic/kibana/pull/115290/files#diff-a4e27aaa05560a7737e153e53fe4bdaf839056180347c338e8d0842ab39f1240R79-R84

So, test from the very beginning was not testing valid use case.

After talking to PR author @marshallmain , we agreed to remove that test
  • Loading branch information
vitaliidm authored Jun 25, 2024
1 parent b20732a commit c47f483
Showing 1 changed file with 0 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,6 @@ export default ({ getService }: FtrProviderContext) => {
await esArchiver.unload('x-pack/test/functional/es_archives/signals/index_alias_clash');
});

// Skipped: see https://github.com/elastic/kibana/issues/179208
it.skip('should report that alerts index does not exist', async () => {
const { body } = await supertest.get(DETECTION_ENGINE_INDEX_URL).send().expect(404);
expect(body).to.eql({ message: 'index for this space does not exist', status_code: 404 });
});

it('should return 200 for create_index', async () => {
const { body } = await supertest
.post(DETECTION_ENGINE_INDEX_URL)
Expand Down

0 comments on commit c47f483

Please sign in to comment.