Skip to content

Commit

Permalink
REMOVE todos
Browse files Browse the repository at this point in the history
added them as issues on gh
  • Loading branch information
mflknr committed Feb 19, 2024
1 parent 2341767 commit 81f35ac
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ struct Outdated: ParsableCommand {
)
var path: String?

// TODO: fix flag
@Flag(name: .long)
var verbose: Bool = false

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

import Foundation

// TODO: streamline error handling and error types
enum ShellOutServiceError: CustomNSError, LocalizedError {
case commandFailed

Expand All @@ -19,7 +18,7 @@ enum ShellOutServiceError: CustomNSError, LocalizedError {
var errorDescription: String? {
switch self {
case .commandFailed:
return "Command to retrieve version from remote repository failed. Use --verbose to see more details."
return "The invoked shell command failed."
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ public final class PackageVersionRemoteDSImpl: PackageVersionRemoteDSInterface {
if let latestVersion = try? shellOutService.run(command: command) {
guard let currentVersionString = resolvedPackage.version,
let currentVersion = Version(currentVersionString) else {
// TODO: handle diff current (e.g. hash)
return []
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ public protocol PrintDependenciesUseCase {
public final class PrintDependenciesUseCaseImpl: PrintDependenciesUseCase {
public init() {}

// TODO: coloring
public func makeTable(from dependencies: [Dependency]) -> String {
let packageNameColumn = TextTableColumn(header: "Package")
let packageUrlColumn = TextTableColumn(header: "URL")
Expand Down

0 comments on commit 81f35ac

Please sign in to comment.