Improvement data store #387
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dev to Main
|
@07jasjeet can you please fix the tests here? |
akshaaatt
requested changes
Apr 15, 2024
| @@ -31,6 +31,7 @@ android { | |||
| dependencies { | |||
| implementation 'androidx.appcompat:appcompat:1.6.1' | |||
| implementation 'com.google.android.material:material:1.11.0' | |||
| implementation "androidx.datastore:datastore-preferences:1.0.0" | |||
There was a problem hiding this comment.
We shouldn't have to add this dependency here if your library already uses it
There was a problem hiding this comment.
Oww it was a save for laptop repair, I guess pushing to origin is not very healthy.
There was a problem hiding this comment.
These changes will be amended please ignore last commit.
| For every new preference, add default value of the concerned shared | ||
| preference as default value here. | ||
| */ | ||
| /* | ||
| class MockAppPreferences( |
There was a problem hiding this comment.
What's to come instead here, now?
| import org.listenbrainz.android.util.BrainzPlayerExtensions.isPrepared | ||
| import org.listenbrainz.android.util.BrainzPlayerExtensions.toSong | ||
| import org.listenbrainz.android.util.BrainzPlayerUtils.MEDIA_ROOT_ID | ||
| import org.listenbrainz.android.util.brainzplayer.BrainzPlayerExtensions.currentPlaybackPosition |
There was a problem hiding this comment.
Totally unrelated change to the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes objective of #347 (Same branch).
Changelog
Used TypesafeDatastore. This implementation results in flexibility, easier use and addition of preferences.