Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* copied beachfront bidder from defunct fork. * debugging cookies * debugging cookies * debugging cookies * debugging cookies * debugging cookies * debugging cookies * trying live endpoint because qa is returning non-usable stuff * back to qa * back to qa * back to qa * back to qa * back to qa * back to qa * back to qa * back to qa * back to qa * back to qa * back to qa * back to qa * back to qa * back to qa * back to qa * back to qa * back to qa * back to qa * back to qa * back to qa * back to qa * back to qa * back to qa * back to qa * back to qa * back to qa * back to qa * back to qa * back to qa * back to qa * back to qa * back to qa * back to qa * got a jam * is that how they want the bid response returned? What happens to bidType? * so adapters.bidResponse is just a wrapper? * so adapters.bidResponse is just a wrapper? * maybe that gets it? * maybe that gets it? * cleaned up debugging a bit * cleaned up debugging a bit * cleaned up debugging a bit * cleaned up debugging a bit * trying a config file * trying a config file * trying a config file * trying a config file * trying a config file * trying a config file * trying a config file * trying a config file * trying a config file * trying a config file * trying a config file * trying a config file * trying a config file * looking at publisher id as the key for getting __io_cid * looking at publisher id as the key for getting __io_cid * looking at publisher id as the key for getting __io_cid * looking at publisher id as the key for getting __io_cid * looking at publisher id as the key for getting __io_cid * looking at publisher id as the key for getting __io_cid * looking at publisher id as the key for getting __io_cid * The usersync endpoint was working yesterday! WHat the hell happened???? * The usersync endpoint was working yesterday! WHat the hell happened???? * The usersync endpoint was working yesterday! WHat the hell happened???? * simplifying usersync * simplifying usersync * simplifying usersync * switched banner request back to a string user and passing the publisher id in for that. * debugging * debugging * debugging * switched banner request back to a string user and passing the publisher id in for that. * switched to a configured usersync URL * typo in the syncer * typo in the syncer * messing with syncer url formatting * messing with syncer url formatting * messing with syncer url formatting * trying live endpoint * trying live endpoint worked - trying live nurl * some code cleanup - making the endpoint selection better * some code cleanup - making the endpoint selection better * some code cleanup - making the endpoint selection better * some code cleanup - making the endpoint selection better * removed some redundant debugging * removed some redundant debugging * trying a test endpoint * nope. * trying to use the built in cookie * trying to use the built in cookie * trying to use the built in cookie * trying to use the built in cookie * trying to use the built in cookie * trying to use the built in cookie * added cookie back to request * added cookie back to request * testing with skip_no_cookie=true * trying platform ID as sync ID. * straightening pout request cookies * Almost ready for my pull request. About to do a merge from upstream which may break it ALLgit add . * trying a default platfor_id * testing a host cookie * that didn't work * cleaned out some glog.Infos * trying multis * trying multis * trying multis * trying multis * trying multis * trying multis * trying multis * trying multis * trying multis * trying multis * trying multis * trying multis * trying multis * got multi banners working, but video still fails. * I've got the 'prefer video' behavior working correctly. Also, video is going to have to be single response only because that's what I get from Beachfront * a few changes to get mixed media working with aliases * added some error tests and multiple format tests * Might fix validation error prebid#538 - The validation error came from this command on the Travis CI build: ./validate.sh --nofmt --cov --race 10 The command worked for me when I ran it locally on go version 1.10.1 and 1.9.3. * go version go1.9.3 darwin/amd64 * go version go1.10.1 darwin/amd64 * both installed with homebrew I then did a pull and ran the command on Beachfront's staging server go version go1.10 linux/amd64 That reproduced the error : gofmt needs to be run, 1 files have issues. Below is a list of files to review: adapters/beachfront/beachfront.go So I ran go fmt to see what it would fix. The diff of this commit will show that the problem was several conditionals where I, being new to Go, used parenthesis. The Darwin builds were letting that slide for whatever reason. The Linux builds were not (I assume that Travis CL is running in a Linux VM somewhere). * Eliminates the JSON template mechanism for the beachfront requests as commented by hhhjort for prebid#538. Also corrected my accidental .gitignore commit. * Eliminates the JSON template mechanism for the beachfront Video requests. * No empty beachfrontReq.Imp by default - they all just get appended as needed. I'm still looking at how to do this using len(req.Imp) as suggested by @hhhjort. * Hit another 'go fmt' discrepency between Mac/Linux. * That straightens out the index clunckyness and gets the test cases back to matching what those produce. I still need to change that to slice. * eliminated some weirdness that resulted from working on this on 2 different boxes so that I can use Linux version of 'go fmt' * cleaned up some of logic related to video / banner requests * Another correction related to Mac/Linux go fmt - prebid#538. This was a result of differences in comment formating. @dbemiller - note that this time when I ran go fmt on the Linux box it 'corrected' some comments in pbs_light.go. I'm not sure if that's OK, as it seems weird that, if the formating was 'wrong' on your master, then all travis CL tests would fail, and specificly brightroll's tests as the 'wrong' formating is in a commented out block of viper.SetDefault code. I've taken care of most of what @hhhjort pointed out, but still not quite there. I'll hold of on commiting though because this looks weird to me.. * forgot to add the len() based index to video. * reformated in Linux to match Travis CI * some documentation updates * Failed on a previous conflict resolution * added some documentation and parameter testing * migrated beachfront viper defaults into the updated config setup * reverted .gitignore to upstream master. I think that in the process of rmoving some changes that I made while debugging, to avoid pushing some notes I was keeping, I accidentally removed a line that I should not have and pushed it. (e6fdab3, ) * Changed the endpoint to a named function. Also added 'expectedBids' to my video tests, but they don't actually seem to be processed. I can put known errors in and validation still passes. I tried putting a known error into the tests for another bidder's expectedBids, and also passed validation. So I'll go over these carefully to make sure that they look right, but I don't think that they are currently being run in the tests. * Moved regex out of the postProcessbanner function, so it will only get compiled once instead of recompiling fro evey banner * This covers all the points that dbemiller pointed out, except the errors for audio / native. So the post processing now works with a slice of bids instead packing and unpacking a seatbid etc. * eliminated the regex for the banner crid. I'm assuming that the string functions are less expensive than compiling a regex. * added race condition parameters and modified some of the Domain/Page logic * updated expectedBids for video to reflect changes to crid extraction * fixed an index out of range error in post process video response * Removed some dead code, some glog output and corrected error type for bad response. * ... except that error needs to be pushed to the stack, not just returned. * improved non-fatal error handling and some clean up
- Loading branch information
