[rilbinder] Implement setupDataCall_1_4. JB#55388 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monich
reviewed
Sep 3, 2021
src/ril_binder_radio.c
Outdated
| ril_binder_radio_take_string(out, &profile->user, user); | ||
| ril_binder_radio_take_string(out, &profile->password, password); | ||
|
|
||
| RADIO_PDP_PROTOCOL_TYPE protocol = RADIO_PDP_PROTOCOL_UNKNOWN; |
There was a problem hiding this comment.
This looks like out-of-order declaration, which is not quite C
monich
reviewed
Sep 3, 2021
src/ril_binder_radio.c
Outdated
| ril_binder_radio_take_string(out, &profile->password, password); | ||
|
|
||
| RADIO_PDP_PROTOCOL_TYPE protocol = RADIO_PDP_PROTOCOL_UNKNOWN; | ||
| if (g_strcmp0(proto, "IPV6") == 0) |
There was a problem hiding this comment.
Please add {} around if blocks for consistency
monich
reviewed
Sep 3, 2021
src/ril_binder_radio.c
Outdated
| } | ||
|
|
||
| ran = RADIO_ACCESS_NETWORK_UNKNOWN; | ||
| switch ((RADIO_TECH)tech) { |
There was a problem hiding this comment.
Is this mapping different from the one in ril_binder_radio_encode_setup_data_call_1_2()? If not, please move it to a separate function and call it from both places.
monich
approved these changes
Sep 3, 2021
Fixes 2G data calls on some devices using [email protected] interface.
|
We got feedback from one user that this does not solve the problem, but we will try to collect more feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 2G data calls on some devices using [email protected] interface. Requires configuration change to enable [email protected] interface for example "transport=binder:name=slot1;[email protected]".in /etc/ofono/ril_subscription.conf.