fix(ex/api/stream_test): fix intermitently failing tests #2303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
joshlarson
reviewed
Dec 7, 2023
| {:ok, conn} = Conn.chunk(conn, "event: ignores unexpected events\n\n") | ||
| {:ok, conn} = Conn.chunk(conn, "ignored garbled data\n\n") | ||
| {:ok, conn} = Conn.chunk(conn, "event: reset\ndata: #{Jason.encode!([data])}\n\n") | ||
| {:ok, conn} = Conn.chunk(conn, "event: add\ndata: #{Jason.encode!(data)}\n\n") |
There was a problem hiding this comment.
Could this introduce flakiness if Jason.encode! doesn't follow the same key order each time?
There was a problem hiding this comment.
I don't believe so, because we're asserting on the type returned and the event returned, but it doesn't seem that we're asserting on any of the JSON data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried fixing this by addressing the Bypass issue, but that didn't actually help. So instead I've decided to cut out the
ServerSentEventsStageand replace it with the parse results thatApi.Streamreceived from the tests before this change.Asana Ticket: ⚙️ Fix false positive test failure in
stream_test.exCI Runs Information
stream_testFailures in #2303 so far14 Successful Jobs