Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-675]: Fixed the inconsistency among the different setting message #389

Merged
merged 6 commits into from
Aug 14, 2024
Merged

[MM-675]: Fixed the inconsistency among the different setting message #389

merged 6 commits into from
Aug 14, 2024

Conversation

Kshitij-Katiyar
Copy link
Contributor

@Kshitij-Katiyar Kshitij-Katiyar commented Aug 12, 2024 •
edited
Loading

Summary

  • Fixed the issue of the inconsistent setting message being posted when running /mscalendar settings command.

Screenshots

Existing

Screenshot from 2024-08-13 18-53-05

Updated

image

Issue link

Fixes #364

@raghavaggarwal2308 raghavaggarwal2308 added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Aug 12, 2024
@raghavaggarwal2308 raghavaggarwal2308 added the Do Not Merge Should not be merged until this label is removed label Aug 13, 2024
@raghavaggarwal2308 raghavaggarwal2308 removed the Do Not Merge Should not be merged until this label is removed label Aug 13, 2024
@AayushChaudhary0001
Copy link

I have noticed an inconsistency in this PR
The actual post for setting the updating status looks different than what is shown in the above screenshot. Please check and verify which one is the correct behavior. I am attaching a screenshot for the same.

image

@Kshitij-Katiyar
Copy link
Contributor Author

I have noticed an inconsistency in this PR The actual post for setting the updating status looks different than what is shown in the above screenshot. Please check and verify which one is the correct behavior. I am attaching a screenshot for the same.

image

@AayushChaudhary0001 I have updated the screenshots to the latest. Can you please re-verify the actual functionality with the screenshots

AayushChaudhary0001
AayushChaudhary0001 approved these changes Aug 14, 2024
View reviewed changes
Copy link

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above PR has been tested and all the changes are working fine, LGTM. Approved.

@raghavaggarwal2308 raghavaggarwal2308 removed 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Aug 14, 2024
@raghavaggarwal2308 raghavaggarwal2308 merged commit abf77ac into master Aug 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AayushChaudhary0001 AayushChaudhary0001 AayushChaudhary0001 approved these changes

@raghavaggarwal2308 raghavaggarwal2308 raghavaggarwal2308 approved these changes

@wiggin77 wiggin77 wiggin77 approved these changes

Assignees

@Kshitij-Katiyar Kshitij-Katiyar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The slack attachments presented to a user on running settings slash command should be consistent.
4 participants
@Kshitij-Katiyar @AayushChaudhary0001 @wiggin77 @raghavaggarwal2308