Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable unused-parameter golangci check #346

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

mickmister
Copy link
Contributor

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (65b2e67) 23.71% compared to head (16d8c6e) 23.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #346   +/-   ##
=======================================
  Coverage   23.71%   23.71%           
=======================================
  Files          62       62           
  Lines        3087     3087           
=======================================
  Hits          732      732           
  Misses       2274     2274           
  Partials       81       81           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mickmister mickmister enabled auto-merge (squash) November 28, 2023 02:57
@hanzei hanzei added the 4: Reviews Complete All reviewers have approved the pull request label Nov 28, 2023
@mickmister
Copy link
Contributor Author

/update-branch

@mickmister mickmister enabled auto-merge (squash) November 28, 2023 16:08
@mickmister
Copy link
Contributor Author

@toninis Any idea why the merge/blocked check is stuck at "Waiting for status to be reported"? I've seen this happen before but don't recall what needs to be done to resolve it

@toninis
Copy link
Contributor

toninis commented Nov 29, 2023

@toninis Any idea why the merge/blocked check is stuck at "Waiting for status to be reported"? I've seen this happen before but don't recall what needs to be done to resolve it

Should be ok . These are some remnants from the webhook URL migration that we forgot to switch 😄

@mickmister
Copy link
Contributor Author

@toninis What needed to be done to unblock this PR? Wondering about other PRs like #267

@toninis
Copy link
Contributor

toninis commented Nov 29, 2023

@toninis What needed to be done to unblock this PR? Wondering about other PRs like #267

An empty commit will do the trick 👍🏼

@mickmister mickmister merged commit f721d3b into master Nov 29, 2023
6 checks passed
@mickmister mickmister deleted the disable-unused-parameter-lint branch November 29, 2023 15:51
@raghavaggarwal2308 raghavaggarwal2308 added this to the v1.3.0 milestone Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants