Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autocompletion to the slash command #161

Merged
merged 32 commits into from
Nov 25, 2024

Conversation

jespino
Copy link
Member

@jespino jespino commented Nov 22, 2024

Summary

This is a PR that adds the ability to have autocompletion for cloud slash commands.

This is made with AI using aider and I was unable to test it properly because I don't have the configuration ready.

Add slash command autocompletion

@mm-cloud-bot mm-cloud-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 22, 2024
Copy link
Contributor

@gabrieljackson gabrieljackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for the contribution.

Would you mind adding a plugin config bool option to enable or disable the autocomplete functionality? The default value can be true, but I would like to have the option to disable it just in case we ever deploy the cloud plugin in the community server again and the security team doesn't want to advertise the plugin to non-MM employees.

@gabrieljackson gabrieljackson added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 25, 2024
Copy link
Contributor

@gabrieljackson gabrieljackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks again.

Adding Nick for one additional review before we merge.

Copy link
Contributor

@nickmisasi nickmisasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gabrieljackson gabrieljackson added the 4: Reviews Complete All reviewers have approved the pull request label Nov 25, 2024
@gabrieljackson gabrieljackson merged commit 0352aff into mattermost:master Nov 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants