Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Electron app crash on macos #3228

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix: Electron app crash on macos #3228

wants to merge 4 commits into from

Conversation

yasserfaraazkhan
Copy link
Contributor 

NONE

@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Nov 26, 2024
@github-actions GitHub Actions
Copy link

Here are the test results below:

Test Summary for Linux on commit a9e7302

The following known failed tests have been fixed on Linux:
- menu/view MM-T820 should open Developer Tools For Application Wrapper for main window

Test Summary for macOS on commit a9e7302

The following known failed tests have been fixed on macOS:
- popup MM-T2827_1 should be able to select all in popup windows

Test Summary for Windows on commit a9e7302

All stable tests passed on Windows.

@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Nov 26, 2024
@yasserfaraazkhan
Copy link
Contributor Author

/update-branch

@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Nov 29, 2024
@github-actions GitHub Actions
Copy link

Here are the test results below:

Test Summary for Linux on commit a1b69f7

The following known failed tests have been fixed on Linux:
- menu/view MM-T820 should open Developer Tools For Application Wrapper for main window

Test Summary for macOS on commit a1b69f7

The following known failed tests have been fixed on macOS:
- popup MM-T2827_1 should be able to select all in popup windows

Test Summary for Windows on commit a1b69f7

New failed tests found on Windows:

  • downloads/downloads_menubar The download list has one file MM-22239 should show the downloads dropdown button and the menu item should be enabled
  • downloads/downloads_menubar The download list has one file MM-22239 should open the downloads dropdown when clicking the download button in the menubar
  • copylink MM-T125 Copy Link can be used from channel LHS
  • menu_bar/dropdown MM-T4405 should set name of menu item from config file
  • menu_bar/dropdown MM-T4407 should open the new server prompt after clicking the add button
  • menu_bar/dropdown MM-T4408 Switch Servers MM-T4408_1 should show the first view
  • menu_bar/dropdown MM-T4408 Switch Servers MM-T4408_2 should show the second view after clicking the menu item
  • file_menu/dropdown MM-T805 Sign in to Another Server Window opens using menu item
  • menu/view MM-T816 Toggle Full Screen in the Menu Bar
  • history_menu Click back and forward from history
  • menu/menu MM-T4404 should open the 3 dot menu with Alt
  • menu/view MM-T813 Control+F should focus the search bar in Mattermost
  • menu/view MM-T817 Actual Size Zoom in the menu bar
  • menu/view MM-T820 should open Developer Tools For Application Wrapper for main window
  • menu/view MM-T818 Zoom in from the menu bar MM-T818_1 Zoom in when CmdOrCtrl+Plus is pressed
  • menu/view MM-T818 Zoom in from the menu bar MM-T818_2 Zoom in when CmdOrCtrl+Shift+Plus is pressed
  • menu/view MM-T819 Zoom out from the menu bar MM-T819_1 Zoom out when CmdOrCtrl+Minus is pressed
  • menu/view MM-T819 Zoom out from the menu bar MM-T819_2 Zoom out when CmdOrCtrl+Shift+Minus is pressed
  • Menu/window_menu MM-T827 select next/previous tab
  • Menu/window_menu MM-T824 should be minimized when keyboard shortcuts are pressed
  • Menu/window_menu MM-T825 should be hidden when keyboard shortcuts are pressed
  • Menu/window_menu MM-T4385 select tab from menu MM-T4385_1 should show the second tab
  • Menu/window_menu MM-T4385 select tab from menu MM-T4385_2 should show the third tab
  • Menu/window_menu MM-T4385 select tab from menu MM-T4385_3 should show the first tab
  • copylink MM-T1308 Check that external links dont open in the app
  • Configure Server Modal MM-T5119 should add the server to the config file
  • server_management/drag_and_drop MM-T2634 should be able to drag and drop servers in the dropdown menu MM-T2634_1 should appear the original order
  • server_management/drag_and_drop MM-T2634 should be able to drag and drop servers in the dropdown menu MM-T2634_2 after dragging the server down, should appear in the new order
  • server_management/drag_and_drop MM-T2634 should be able to drag and drop servers in the dropdown menu MM-T2634_3 should update the config file
  • server_management/drag_and_drop MM-T2635 should be able to drag and drop tabs MM-T2635_1 should be in the original order
  • server_management/drag_and_drop MM-T2635 should be able to drag and drop tabs MM-T2635_2 after moving the tab to the right, the tab should be in the new order
  • server_management/drag_and_drop MM-T2635 should be able to drag and drop tabs MM-T2635_3 should update the config file
  • EditServerModal MM-T4391_2 should edit server when Save is pressed and name edited
  • EditServerModal MM-T4391_3 should edit server when Save is pressed and URL edited
  • EditServerModal MM-T4391_4 should edit server when Save is pressed and both edited
  • header MM-T2637 Double-Clicking on the header should minimize/maximize the app MM-T2637_2 should restore on double-clicking the header when maximized
  • RemoveServerModal MM-T4390_1 should remove existing server on click Remove
  • Settings Options Check spelling MM-T4397 should appear and be selectable
  • Settings Options Enable GPU hardware acceleration MM-T4398 should save selected option
  • Settings Options Enable automatic check for updates MM-T4549 should save selected option
  • startup/app MM-T4975 should show the welcome screen modal when no servers exist
  • startup/app MM-T4985 should show app name in title bar when no servers exist
  • config MM-T4402 should upgrade v0 config file
  • config MM-T4401 should show servers in dropdown when there is config file MM-T4401_1 should show correct server in the dropdown button
  • config MM-T4401 should show servers in dropdown when there is config file MM-T4401_2 should set src of browser view from config file
  • Welcome Screen Modal MM-T4976 should show the slides in the expected order
  • Welcome Screen Modal MM-T4977 should be able to move through slides clicking the navigation buttons
  • Welcome Screen Modal MM-T4978 should be able to move through slides clicking the pagination indicator
  • Welcome Screen Modal MM-T4979 should be able to move forward through slides automatically every 5 seconds
  • Welcome Screen Modal MM-T4980 should show the slides in the expected order
  • Welcome Screen Modal MM-T4981 should be able to move from last to first slide
  • Welcome Screen Modal MM-T4982 should be able to move from first to last slide
  • Welcome Screen Modal MM-T4983 should be able to click the get started button and be redirected to new server modal
  • window MM-T4403_1 should restore window bounds

@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Nov 29, 2024
@yasserfaraazkhan
Copy link
Contributor Author

/update-branch

@mattermost-build
Copy link
Contributor

Error trying to update the PR.
Please do it manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yasserfaraazkhan @mattermost-build @mm-cloud-bot