Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile additions #107

Merged
merged 1 commit into from
May 30, 2024
Merged

Mobile additions #107

merged 1 commit into from
May 30, 2024

Conversation

stefanceriu
Copy link
Member

  • add screen for Element Call
  • add interaction for when tapping on the call button within a room
  • add event for toggling the formatting option on the room's composer

@stefanceriu stefanceriu requested a review from a team as a code owner May 30, 2024 06:29
@stefanceriu stefanceriu requested a review from langleyd May 30, 2024 06:29
jmartinesp
jmartinesp approved these changes May 30, 2024
View reviewed changes
Copy link

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

pixlwave
pixlwave approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, discussed a couple of possible tweaks offline:

  • Distinguishing internal and external calls in the future
  • Only caring if the user enables the RTE.

@stefanceriu
Mobile additions:
b918f99 
* add screen for an Element Call started in a room
* add interaction for when tapping on the call button within a room
* add event for enabling the formatting option on the room's composer
@stefanceriu stefanceriu merged commit de0cac4 into main May 30, 2024
3 checks passed
@stefanceriu stefanceriu deleted the stefan/mobileAdditions branch May 30, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinesp jmartinesp jmartinesp approved these changes

@pixlwave pixlwave pixlwave approved these changes

@langleyd langleyd Awaiting requested review from langleyd langleyd is a code owner automatically assigned from matrix-org/analytics-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanceriu @jmartinesp @pixlwave