Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add NEB schemas #1123

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

esoteric-ephemera
Copy link
Collaborator

Adding support for parsing NEB calculations and eventually ApproxNEB calculations. These are still VASP calculations, but have a directory structure which is not parseable by TaskDoc (at least meaningfully). The structure is:
./{INCAR, KPOINTS, POTCAR}
./00/POSCAR
./01/{vasprun.xml, OSZICAR, OUTCAR, CHGCAR, ... }
./02/{vasprun.xml, OSZICAR, OUTCAR, CHGCAR, ... }
...
./0N/POSCAR

Approx / NEB calculations are needed for battery cathode and alloy diffusivity calculations. These schemas will be needed for atomate2 workflows. Once Approx / NEB flows are added to atomate2, we should have full parity with atomate. This will also make it easier to host data from these calculations

WIP because the document structure may need to change. Right now, this structure supports NEB calcs well but need to add some extra logic for ApproxNEB style calcs

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.26%. Comparing base (14a5e4b) to head (b1cb7c9).

Files with missing lines Patch % Lines
emmet-core/emmet/core/tasks.py 0.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (14a5e4b) and HEAD (b1cb7c9). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (14a5e4b) HEAD (b1cb7c9)
6 2
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1123       +/-   ##
===========================================
- Coverage   89.97%   72.26%   -17.71%     
===========================================
  Files         143       77       -66     
  Lines       13756     5153     -8603     
===========================================
- Hits        12377     3724     -8653     
- Misses       1379     1429       +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants