-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: GW workflow with VASP #808
base: main
Are you sure you want to change the base?
Feat: GW workflow with VASP #808
Conversation
…e MVLGWSetGenerator
… band structure calculation
This PR is ready for review now. In this PR, I have implemented a simple workflow to run GW calculations in atomate2 with the setup defined in the MVLGWSet in pymatgen. Here I summarize what has been done in more detail:
Please note that benchmarks of the setups are not done yet. One can only get the level of accuracy at the MVLGWSet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I've put some comments for you.
One thing to note is that in VASP v6.3 there is the option to do a single step GW calculation (i.e., no need for separate static+gw) which simplifies everything. E.g., see the manual here: https://www.vasp.at/wiki/index.php/Practical_guide_to_GW_calculations
As the MVL workflow is quite old, it could be nice to support this newer approach (potentially in a future PR).
@utf I have reorganized the codes as you suggested. Thanks for the suggestions, and it makes a lot more sense now. Except the setting of NELM for the non-self-consistent calculations. Please let me know what you think. Thanks!
As for this suggestion, I think it is more reasonable to add it in future PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yanghan234, this is almost there now. Please see the final comment (I believe we will need a PR to custodian to keep the calculation procedure optimal).
I have updated the codes and testcases accordingly. Now, the NELM issue is solved. Once the PRs in emmet and pymatgen repos are merged, this PR should be good to go. Thanks for the comments. @utf |
Awesome, thanks @yanghan234. |
Summary
This is a work-in-progress PR to implement a GW workflow with VASP, as proposed in #800.
TODO